Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] Fix build arg for templates #5849

Merged
merged 1 commit into from
Jun 25, 2024
Merged

[cherry-pick] Fix build arg for templates #5849

merged 1 commit into from
Jun 25, 2024

Conversation

nginx-bot
Copy link
Contributor

Proposed changes

Fix for issue found in #5838

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-bot nginx-bot requested a review from a team as a code owner June 25, 2024 10:00
@nginx-bot nginx-bot added dependencies Pull requests that update a dependency file docker Pull requests that update Docker code needs cherry pick Cherry pick this PR into a release branch labels Jun 25, 2024
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jun 25, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) June 25, 2024 10:34
@pdabelf5 pdabelf5 merged commit e140259 into release-3.6 Jun 25, 2024
65 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-release-3.6-df72b9caeb543542feb57b926804953bb52e54ae branch June 25, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdabelf5 pdabelf5 pdabelf5 approved these changes

@oseoin oseoin oseoin approved these changes

Assignees
No one assigned
Labels
docker Pull requests that update Docker code needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nginx-bot @oseoin @pdabelf5